chore: Separate trunk tests and trigger weekly#1926
Merged
ashwinimurt merged 4 commits intodevelopfrom May 4, 2022
Merged
Conversation
0xFA11
approved these changes
May 3, 2022
Contributor
Author
|
Will be backported to |
0xFA11
reviewed
May 4, 2022
| - pip install unity-downloader-cli --upgrade --index-url https://artifactory.prd.it.unity3d.com/artifactory/api/pypi/pypi/simple | ||
| - npm install upm-ci-utils@stable -g --registry https://artifactory.prd.cds.internal.unity3d.com/artifactory/api/npm/upm-npm | ||
| - unity-downloader-cli -u trunk -c editor --wait --fast | ||
| - unity-downloader-cli -u {{ validation_editor }} -c editor --wait --fast |
Contributor
There was a problem hiding this comment.
where did you set validation_editor variable?
if only yamato ui, I'd suggest adding this variable to project.metafile as a fallback when yamato variable is not set.
ashwinimurt
added a commit
that referenced
this pull request
May 5, 2022
* chore: Separate trunk tests and trigger weekly * Rename to weekly * Turn off badges trigger dependencies on trunk * Run Code Coverage on validation_editor 2020.3
0xFA11
added a commit
that referenced
this pull request
May 5, 2022
* chore: Separate trunk tests and trigger weekly (#1926) * chore: Separate trunk tests and trigger weekly * Rename to weekly * Turn off badges trigger dependencies on trunk * Run Code Coverage on validation_editor 2020.3 * fix: Fix code coverage config name in nightly trigger (#1933) * docs: NetworkConfig.ClientConnectionBufferTimeout xmldoc clarifications [skip ci] (#1927) Add more detail to where in the process the setting takes effect, how it relates to transport-level timeouts and indicates that it's a server-side setting only. * chore: update `CODEOWNERS` (#1935) Co-authored-by: Jesse Olmer <jesseo@unity3d.com> Co-authored-by: Fatih Mar <mfatihmar@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separate trunk tests and trigger weekly.
Trunk runs
Weekly Trigger
Nightly
Update Code Coverage Tests to run on
validation editor- 2020.3 at the moment.Changelog
n/a
Testing and Documentation
n/a